Closed
Conversation
Currently we are enabling "rand" using a path dependency in the dev-dependencies because of the benches. This is reducing coverage in CI because "std" is always enabled. Feature gate the bench that requires "rand" and remove the path dependency.
We use a range dependency for `bitcoin_hashes`, the different allowed versions each have a different MSRV, which implies using each changes the MSRV of `bip39`.
tcharding
force-pushed
the
test-bitcoin
branch
2 times, most recently
from
9a6f54e to
ee5ce45
Compare
We just release a new version of `bitcoin_hashes` which works with `bip39` with no changes. Add `bitcoin_hashes v0.14` to the dependency range and document its effect on the MSRV. (Note, the "alloc" feature is required as of 0.14).
Collaborator
|
Can this be closed @tcharding? |
Member
Author
|
Can be, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch is not a merge candidate.
Test branch for testing the latest RC release of
rust-bitcoin.